Skip to content

Schemas#340

Closed
deniszgonjanin wants to merge 4 commits into
apache:masterfrom
deniszgonjanin:schemas
Closed

Schemas#340
deniszgonjanin wants to merge 4 commits into
apache:masterfrom
deniszgonjanin:schemas

Conversation

@deniszgonjanin
Copy link
Copy Markdown

@deniszgonjanin deniszgonjanin commented Apr 13, 2016

This PR adds support for specifying database schemas when creating a new database source. I've tested it against redshift. It should address all or parts of the following: #336, #325, and #252, and #217.

To specify a schema, create a data source with the schema specified in the extras, like so:

{
    "metadata_params": {
          "schema":"myschema"
     },
    "engine_params": {
          "connect_args":{
        }
     }
}

Note that it does specify the schema right on the database source, and not on individual tables. I think this is preferable, so that you don't have to specify schemas on every table you create. You can also segment your database sources based on the schema you are using, which is probably what you want anyway.

@deniszgonjanin deniszgonjanin mentioned this pull request Apr 13, 2016
Merged
@landscape-bot
Copy link
Copy Markdown

landscape-bot commented Apr 13, 2016

Code Health
Code quality remained the same when pulling 76f1838 on deniszgonjanin:schemas into af417b6 on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 13, 2016

Coverage Status

Coverage increased (+0.06%) to 72.559% when pulling 76f1838 on deniszgonjanin:schemas into af417b6 on airbnb:master.

@mistercrunch
Copy link
Copy Markdown
Member

mistercrunch commented Apr 13, 2016

#330 allows specifying the schema when adding the table

graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
@ktmud
fix(legacy-plugin-chart-table): time column formating (apache#340)
6c7f710
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-table): time column formating (apache#340)
2b7e12f
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/addon-links from 5.0.11 to 5.3.13 (apach…
faf6e49 
…e#340)

Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 5.0.11 to 5.3.13.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.13/addons/links)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-table): time column formating (apache#340)
545f04c
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/addon-links from 5.0.11 to 5.3.13 (apach…
fe82e5d 
…e#340)

Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 5.0.11 to 5.3.13.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.13/addons/links)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-table): time column formating (apache#340)
ef0be66
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/addon-links from 5.0.11 to 5.3.13 (apach…
174cdb2 
…e#340)

Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 5.0.11 to 5.3.13.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.13/addons/links)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-table): time column formating (apache#340)
21f82d2
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @storybook/addon-links from 5.0.11 to 5.3.13 (apach…
2f665b9 
…e#340)

Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 5.0.11 to 5.3.13.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.13/addons/links)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deniszgonjanin @landscape-bot @coveralls @mistercrunch